Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(invoice): Faster return amount query #36556

Merged
merged 1 commit into from
Aug 9, 2023
Merged

perf(invoice): Faster return amount query #36556

merged 1 commit into from
Aug 9, 2023

Conversation

ankush
Copy link
Member

@ankush ankush commented Aug 9, 2023 •
edited
Loading

Coalesce is not required here. Read this for more info: frappe/frappe#21822

Before

+------+-------------+----------------+------+---------------+------+---------+------+--------+-------------+
| id   | select_type | table          | type | possible_keys | key  | key_len | ref  | rows   | Extra       |
+------+-------------+----------------+------+---------------+------+---------+------+--------+-------------+
|    1 | SIMPLE      | tabPOS Invoice | ALL  | NULL          | NULL | NULL    | NULL | 390850 | Using where |
+------+-------------+----------------+------+---------------+------+---------+------+--------+-------------+

After

+------+-------------+----------------+------+----------------------+----------------------+---------+-------+------+------------------------------------+
| id   | select_type | table          | type | possible_keys        | key                  | key_len | ref   | rows | Extra                              |
+------+-------------+----------------+------+----------------------+----------------------+---------+-------+------+------------------------------------+
|    1 | SIMPLE      | tabPOS Invoice | ref  | return_against_index | return_against_index | 563     | const | 1    | Using index condition; Using where |
+------+-------------+----------------+------+----------------------+----------------------+---------+-------+------+------------------------------------+

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 9, 2023
@ankush ankush added backport version-13-hotfix backport version-14-hotfix backport to version 14 frappe-support and removed needs-tests This PR needs automated unit-tests. labels Aug 9, 2023
@ankush ankush changed the title perf: Faster return amount query perf(invoice): Faster return amount query Aug 9, 2023
@ankush ankush merged commit b0c79a0 into frappe:develop Aug 9, 2023
13 of 14 checks passed
@ankush ankush deleted the faster_return_queries branch August 9, 2023 08:07
mergify bot pushed a commit that referenced this pull request Aug 9, 2023
@ankush @mergify
perf(invoice): Faster return amount query (#36556)
78399c3 
perf: Faster return amount query
(cherry picked from commit b0c79a0)
@mergify mergify bot mentioned this pull request Aug 9, 2023
Merged
mergify bot pushed a commit that referenced this pull request Aug 9, 2023
@ankush @mergify
perf(invoice): Faster return amount query (#36556)
3c913ae 
perf: Faster return amount query
(cherry picked from commit b0c79a0)
@mergify mergify bot mentioned this pull request Aug 9, 2023
Merged
ankush added a commit that referenced this pull request Aug 9, 2023
@mergify @ankush
perf(invoice): Faster return amount query (backport #36556) (#36557)
fe41be9 
perf(invoice): Faster return amount query (#36556)

perf: Faster return amount query
(cherry picked from commit b0c79a0)

Co-authored-by: Ankush Menat <ankush@frappe.io>
ankush added a commit that referenced this pull request Aug 9, 2023
@mergify @ankush
perf(invoice): Faster return amount query (backport #36556) (#36558)
a801bba 
perf(invoice): Faster return amount query (#36556)

perf: Faster return amount query
(cherry picked from commit b0c79a0)

Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot pushed a commit that referenced this pull request Aug 16, 2023
@frappe-bot
chore(release): Bumped to Version 13.52.10
8f977f4 
## [13.52.10](v13.52.9...v13.52.10) (2023-08-16)

### Bug Fixes

* Allow backdated repayment cancels for term loans ([c417365](c417365))
* payment allocation in invoice payment schedule ([#36440](#36440)) ([e5b3860](e5b3860))

### Performance Improvements

* **invoice:** Faster return amount query (backport [#36556](#36556)) ([#36558](#36558)) ([a801bba](a801bba))
frappe-pr-bot pushed a commit that referenced this pull request Aug 16, 2023
@frappe-bot
chore(release): Bumped to Version 14.35.0
b773465 
# [14.35.0](v14.34.3...v14.35.0) (2023-08-16)

### Bug Fixes

* Allow backdated repayment cancels for term loans ([1377cf4](1377cf4))
* allow negative stock condition for batch item ([#36586](#36586)) ([ee04c6d](ee04c6d))
* AR/AP report based on payment terms ([#36574](#36574)) ([ac0fff7](ac0fff7))
* better remarks on Cr note created by Reconciliation ([5443592](5443592))
* Button Alignment center in hero slider ([#36607](#36607)) ([b131f70](b131f70)), closes [#36561](#36561)
* cr/dr note should be posted for exc gain/loss ([349601b](349601b))
* disallow mulitple SO with same PO No ([b901cfd](b901cfd))
* don't show disabled items in `Item Shortage Report` (backport [#36550](#36550)) ([#36571](#36571)) ([19cfcea](19cfcea))
* fetch `Stock UOM` from Item if not set (backport [#36606](#36606)) ([#36617](#36617)) ([8b13185](8b13185))
* Group Account total not showing in Financial Statements ([2912648](2912648))
* incorrect available qty for backdated stock reco with batch ([#36581](#36581)) ([2800ad3](2800ad3))
* incorrect gain/loss on allocation change on reconciliation tool ([39c439d](39c439d))
* Make default sales update frequency as monthly instead of each transaction ([4ca1f3b](4ca1f3b))
* move company rename to long queue ([8083c0b](8083c0b))
* precision issue while submitting the stock entry ([#36575](#36575)) ([a864e07](a864e07))
* re-add permission that was unintentionally removed ([#36663](#36663)) ([99777d3](99777d3))
* **RFQ:** link to supplier portal ([eb2f68e](eb2f68e))
* standard formula to calculate the "difference" ([#36612](#36612)) ([716d5c0](716d5c0))
* Tax withholding post LDC limit consumed ([#36611](#36611)) ([1deebe8](1deebe8))
* **test:** replace hardcoded reference to adv with dynamic one ([2e6bfa3](2e6bfa3))
* **test:** test case breakage in Github Actions ([3542df7](3542df7))
* unhide `uom` and `stock_uom` fields in print view ([b49309c](b49309c))
* validation blocks partial payment for SO and PO ([ce08f03](ce08f03))
* wrap none type rate under flt (backport [#36602](#36602)) ([#36604](#36604)) ([63c061e](63c061e))
* wrong currency on financial-statement based reports ([#36524](#36524)) ([3044f46](3044f46))

### Features

* add voucher totals in tds payable report ([#36568](#36568)) ([90b390c](90b390c))
* daily asset depreciation method ([#36587](#36587)) ([2918127](2918127))
* Reallow customizing company abbreviation on setup. ([#36646](#36646)) ([ca34b63](ca34b63))

### Performance Improvements

* **invoice:** Faster return amount query (backport [#36556](#36556)) ([#36557](#36557)) ([fe41be9](fe41be9))
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees
No one assigned
Labels
backport version-13-hotfix backport version-14-hotfix backport to version 14 frappe-support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ankush